Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDISCROWD-7338 project password --> assign user to project #459

Merged
merged 8 commits into from
Aug 7, 2024

Conversation

n00rsy
Copy link

@n00rsy n00rsy commented Jul 29, 2024

Issue number of the reported bug or feature request: RDISCROWD-7338

Describe your changes

  • enable assigning users to projects
  • remove project password button in project settings

Remove Project Password Button:
image

UPDATED BUTTON:
image

Confirmation alert:
image

@n00rsy n00rsy changed the title assign users to project in all envs RDISCROWD-7338 assign users to project in all envs Jul 29, 2024
kbecker42
kbecker42 previously approved these changes Jul 29, 2024
@@ -62,6 +62,14 @@ <h3>{{_('Enable project syncing')}}</h3>
</div>
</fieldset>
</form>
<br>
<form id="remove-password-form" method="post" action="{{ url_for('project.remove_password', short_name = project.short_name) }}">
Copy link

@kbecker42 kbecker42 Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably include a conditional per here:

{% if !config.get('PROJECT_PASSWORD_REQUIRED') %}
  <form id="remove-password-form" method="post" action="{{ url_for('project.remove_password', short_name = project.short_name) }}">
      <div class="form-actions">
          <input type="hidden" name="csrf_token" value="{{ csrf_token() }}" />
          <input type="hidden" name="password" value="" />
          <button type="submit" class="btn btn-link" value="Remove Project Password">{{_('Remove Project Password')}}</button>
      </div>
  </form>
{% endif %}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Implemented via b613336

@n00rsy n00rsy changed the title RDISCROWD-7338 assign users to project in all envs RDISCROWD-7338 project password --> assign user to project Aug 7, 2024
@n00rsy n00rsy merged commit 46d53fb into main Aug 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants