Fix all tests and squash into one #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before Iceberg library gained Puffin stats, Trino would store table stats in Iceberg table properties. This became obsoleted in Trino 405 (released in Dec 2022). Dropping support for old stats format means need to re-analyze tables that haven't been written to by Trino 405 or newer.
Table/view not found can be indicated by `TrinoException` with `TABLE_NOT_FOUND` error code, but also by `TableNotFoundException` or `ViewNotFoundException` exceptions (both using `NOT_FOUND` error code). The code catching "not found" exceptions should catch all three.
The information was not correct when ANALYZE was invoked without `columns` parameter -- instead of all columns, an empty set was there. The information can be replaced with a single boolean.
ValuesStatsRule is calling evaluateConstantExpression which might fail for certain expressions like division by 0.
It's no longer needed as stats rules have been improved
If stats collection was not requested explicitly, then use statistics that were fetched and cached during planning.
When concurrency is not involved, it is not needed and when it is involved, it doesn't provide more correctness. FWIW, the `system.jdbc.tables` doesn't have similar set unioning.
Prevent passing impossible names down to the connectors. E.g. prevents failures if a connector chooses to convert input to something that validates name is not impossible, like `SchemaTablePrefix`.
`listMaterializedViews` can return names already included in metastore's relation listing.
Ignore failure within stage execution if it already done. This is to work around the problem which was introduced with trinodb@39b04491c05. With that change we close EventDrivenTaskSource when stage completes, and as a result of that it may emit an failure event due to internall processes being cancelled. Handling of event in `StageExecution.fail()` did close a number of objects needed for query completion (see createStageExecutionCloser()). As a result the query could hang.
… Server Co-Authored-By: Jonas Haag <jonas@lophus.org>
github-actions
bot
added
tests:hive
docs
jdbc
bigquery
delta-lake
hive
hudi
iceberg
mongodb
release-notes
labels
yuuteng
force-pushed
the
bloomberg-snowflake
branch
from
3a0411e
to
c4ff5fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all tests and squash into one