Improving script and function argument handling #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents (not allowed for command-line, allowed for python function call)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial attempt to resolve #111 , ultimately a part of #6 .
The first commit is an attempt to handle the need for strict handling of unrecognised arguments during command-line operation, while also being flexible when the scripts are being called internally - in this instance, when
get_scenario_inputs. I am detecting whether arguments have been passed directly to the function argument, or viasys.argv. Based on that, I'm taking inspiration from @gerritdm 's posts in the issue and his work in the viz suite.Please review. If this looks okay, I will do this for all the other argument parsing entry points. Other cleanup will then follow.