Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use kzg-rs for kzg point evaluation #1558

Merged
merged 17 commits into from
Jul 10, 2024
Merged

Conversation

0xWOLAND
Copy link
Contributor

Currently, revm uses c-kzg for KZG point evaluation. It would be useful to have a [no_std] endpoint for this, which kzg-rs can be used for.

@rakita
Copy link
Member

rakita commented Jun 24, 2024

Needs to be checked that it compiles with --all-feature and --no-default-features

@0xWOLAND 0xWOLAND force-pushed the kzg-rs branch 11 times, most recently from 474d52b to 746f037 Compare June 28, 2024 03:46
@0xWOLAND 0xWOLAND requested a review from rakita June 28, 2024 03:52
@0xWOLAND 0xWOLAND force-pushed the kzg-rs branch 2 times, most recently from 676d1c9 to fc4cd81 Compare June 28, 2024 22:55
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits left. Others things lgtm

@0xWOLAND 0xWOLAND requested a review from rakita July 1, 2024 18:09
@rakita rakita changed the base branch from main to release-plz-2024-06-30T01-05-28Z July 8, 2024 12:19
@rakita rakita changed the base branch from release-plz-2024-06-30T01-05-28Z to main July 8, 2024 12:19
@rakita
Copy link
Member

rakita commented Jul 8, 2024

@0xWOLAND can you merge with newest main, PR changes show me diffs of code not related to this PR

crates/primitives/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revm/Cargo.toml should have kzg-rs feature.

edit: Should add it to revm-interpreter too

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@rakita
Copy link
Member

rakita commented Jul 10, 2024

@0xWOLAND added a few comments for new feature. Will merge PR after CI

@rakita rakita merged commit 2b25469 into bluealloy:main Jul 10, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request Jul 16, 2024
j75689 pushed a commit to j75689/revm that referenced this pull request Aug 1, 2024
* feat: use `kzg-rs`

* fix: use `c-kzg` by default in std env

* refactor: feature gate by `c-kzg`

* fix: use published crate

* fix: `kzg-rs` import

* feat: use `cfg_if` for `kzg-rs` imports

* feat: use `kzg-rs`

* fix: `kzg-rs` import

* chore: add `kzg-rs` feature to revm-interpreter

* fix: check kzg-rs enable in revm/precompile

* fix: kzg-rs include once_cell and derive_more in primitives, update feature tags

* Update crates/primitives/src/lib.rs

* Update crates/precompile/src/lib.rs

* Update crates/primitives/Cargo.toml

* Update crates/revm/Cargo.toml

* Update crates/precompile/Cargo.toml

* Update crates/primitives/src/lib.rs

---------

Co-authored-by: rakita <rakita@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants