-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use kzg-rs
for kzg point evaluation
#1558
Conversation
Needs to be checked that it compiles with |
474d52b
to
746f037
Compare
676d1c9
to
fc4cd81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits left. Others things lgtm
@0xWOLAND can you merge with newest main, PR changes show me diffs of code not related to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revm/Cargo.toml should have kzg-rs
feature.
edit: Should add it to revm-interpreter
too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
@0xWOLAND added a few comments for new feature. Will merge PR after CI |
* feat: use `kzg-rs` * fix: use `c-kzg` by default in std env * refactor: feature gate by `c-kzg` * fix: use published crate * fix: `kzg-rs` import * feat: use `cfg_if` for `kzg-rs` imports * feat: use `kzg-rs` * fix: `kzg-rs` import * chore: add `kzg-rs` feature to revm-interpreter * fix: check kzg-rs enable in revm/precompile * fix: kzg-rs include once_cell and derive_more in primitives, update feature tags * Update crates/primitives/src/lib.rs * Update crates/precompile/src/lib.rs * Update crates/primitives/Cargo.toml * Update crates/revm/Cargo.toml * Update crates/precompile/Cargo.toml * Update crates/primitives/src/lib.rs --------- Co-authored-by: rakita <rakita@users.noreply.github.com>
Currently,
revm
usesc-kzg
for KZG point evaluation. It would be useful to have a[no_std]
endpoint for this, whichkzg-rs
can be used for.