Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EOF): MIN_CALLEE_GAS light failure, static-mode check #1599

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Jul 10, 2024

Add static check for EXTCALL.

MIN_CALLEE_GAS check should be a light failure and callee, not on the caller.

Copy link
Contributor

github-actions bot commented Jul 10, 2024

Valgrind Results:

==3926== Cachegrind, a cache and branch-prediction profiler
==3926== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3926== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3926== Command: target/release/snailtracer
==3926== 
--3926-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.841913914s
==3926== 
==3926== I   refs:      427,040,429
==3926== I1  misses:          4,750
==3926== LLi misses:          2,824
==3926== I1  miss rate:        0.00%
==3926== LLi miss rate:        0.00%
==3926== 
==3926== D   refs:      204,077,353  (132,268,960 rd   + 71,808,393 wr)
==3926== D1  misses:        341,498  (    201,475 rd   +    140,023 wr)
==3926== LLd misses:        137,811  (      4,492 rd   +    133,319 wr)
==3926== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3926== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3926== 
==3926== LL refs:           346,248  (    206,225 rd   +    140,023 wr)
==3926== LL misses:         140,635  (      7,316 rd   +    133,319 wr)
==3926== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita changed the title Rakita/eof min callee static mode fix(EOF): MIN_CALLEE_GAS light failure, static-mode check Jul 10, 2024
@rakita rakita merged commit 7f8e31a into main Jul 10, 2024
26 checks passed
@rakita rakita deleted the rakita/eof_min_callee_static_mode branch July 10, 2024 15:33
j75689 pushed a commit to j75689/revm that referenced this pull request Aug 1, 2024
…1599)

* fix(EOF): MIN_CALLEE_GAS light failure, static-mode check

* clear buffer

* readd min caller gas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant