Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(GeneralState): skip fewer specs #1603

Merged
merged 1 commit into from
Jul 11, 2024
Merged

test(GeneralState): skip fewer specs #1603

merged 1 commit into from
Jul 11, 2024

Conversation

hai-rise
Copy link
Contributor

@hai-rise hai-rise commented Jul 11, 2024 •
edited
Loading

  • SpecName::Unknown previously only covered Paris, which should be mapped to SpecId::MERGE instead of Merge (not used in GeneralStateTests).
  • Removed the skip on SpecName::ByzantiumToConstantinopleAt5 as its tests are passing.
  • Left a comment on why we skip Constantinople.

@hai-rise hai-rise changed the title Skip fewer GeneralStateTests specs test(GeneralState): skip fewer specs Jul 11, 2024
rakita
rakita approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 6e082a8 into bluealloy:main Jul 11, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request Jul 11, 2024
Closed
@hai-rise hai-rise deleted the skip-fewer-general-state-test-specs branch July 11, 2024 08:31
This was referenced Jul 12, 2024
Closed
Closed
Closed
Merged
j75689 pushed a commit to j75689/revm that referenced this pull request Aug 1, 2024
@hai-rise @j75689
test(GeneralState): skip fewer specs (bluealloy#1603)
939cef6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hai-rise @rakita