Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(revme): use Osaka for state test results #1844

Closed
wants to merge 3 commits into from

Conversation

Rjected
Copy link
Collaborator

@Rjected Rjected commented Nov 1, 2024

These two ethereum/tests commits:
ethereum/tests@6e878df (adds osaka)
ethereum/tests@4c87ebb (removes prague)

changed the result key from Prague to Osaka, so we change it here as well

opened this to fix the statetest CI, which is failing in #1843

@Rjected Rjected added bug Something isn't working ci CI related labels Nov 1, 2024
we must be using the version with both values for some reason, so
instead let's use the osaka value (afaik it should be the same?)
@Rjected
Copy link
Collaborator Author

Rjected commented Nov 14, 2024

Closing this, I think there's more work needed for this

@Rjected Rjected closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci CI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant