Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Option for prereleases #8

Merged
merged 4 commits into from
Feb 24, 2024
Merged

feat: Option for prereleases #8

merged 4 commits into from
Feb 24, 2024

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Feb 24, 2024

No description provided.

spydon
spydon reviewed Feb 24, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just one comment

action.yml Outdated Show resolved Hide resolved
@Gustl22
Copy link
Collaborator Author

Gustl22 commented Feb 24, 2024

Also thought to shorten it to run-versioning-pre, but don't know if you would prefer the long variant.

@spydon
Copy link
Member

spydon commented Feb 24, 2024

Also thought to shorten it to run-versioning-pre, but don't know if you would prefer the long variant.

I think the long variant is fine, or I can't come up with any that is better at least 😅

@spydon spydon merged commit a866009 into bluefireteam:main Feb 24, 2024
@Gustl22 Gustl22 deleted the patch-1 branch February 24, 2024 18:25
@Gustl22
Copy link
Collaborator Author

Gustl22 commented Feb 25, 2024 •
edited
Loading

@spydon could we re-release v3 with this change (as not breaking) to work with bluefireteam/audioplayers#1760 ? That would be great :D
Prerelease is passing with creating a PR.

@spydon
Copy link
Member

spydon commented Feb 25, 2024

@spydon could we re-release v3 with this change

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gustl22 @spydon