-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix EOF error for some files without final newline (#27)
If a file was an exact multiple of 1024 bytes (the size of an internal buffer) and was missing a final newline, the LineReaderAt implementation would drop the last line, leading to an unexpected EOF error on apply. In addition to fixing the bug, slightly change the behavior of ReadLineAt to reflect how it is actually used: 1. Clarify that the return value n includes all lines instead of only lines with a final newline. This was already true except in the case of the bug fixed by this commit. 2. Only return io.EOF if fewer lines are read than requested. The previous implementation also returned io.EOF if the last line was missing a final newline, but this was confusing and didn't really serve a purpose. This is technically a breaking change for external implementations but an implementation that exactly followed the "spec" was already broken in certain edge cases.
- Loading branch information
Showing
3 changed files
with
77 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters