Use GAction where possible #1927
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infirit
changed the title
infirit
changed the title
infirit
force-pushed
the
gaction
branch
2 times, most recently
from
d34f7be to
84b1c81
Compare
1 task
infirit
changed the title
1 task
This comment was marked as outdated.
This comment was marked as outdated.
|
I have reworked this a bit and added wip ManagerDeviceList actions. I am thinking now how to handle plugins... I'll split off the keyboard shortcuts into a separate PR soon. |
1 task
infirit
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually we will need to drop the current menu's for something else. In preparation I wanted to move all "regular" menuitem callbacks to GAction as pretty much all replacements will use them . Sadly RadioMenuItems don't work with GAction 😞.
I think it would be good to do as much as possible so marked it for review. Also included accelerators for closing windows and apps.