Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AutoConnectConfig.py #2582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

UmairShafiqu3
Copy link

Key Changes:

1. Corrected the import path for BtAddress to blueman.bluez.BtAddress. # 2. Converted the "services" key values to a list when setting them in switch to match Gio.Settings expectations. # 3. Grouped imports from gi.repository to a single line for simplicity. # 4. Ensured logical flow and type consistency for data and services. Use list instead of set when assigning to Gio.Settings values

# Key Changes:
# 1. Corrected the import path for BtAddress to `blueman.bluez.BtAddress`.
# 2. Converted the "services" key values to a list when setting them in `switch` to match Gio.Settings expectations.
# 3. Grouped imports from `gi.repository` to a single line for simplicity.
# 4. Ensured logical flow and type consistency for `data` and `services`. Use `list` instead of `set` when assigning to Gio.Settings values
@infirit
Copy link
Contributor

infirit commented Dec 25, 2024

I little confused with all of this.

  1. blueman.bluez.BtAddress does not exist
  2. The use of a set is intentional as duplicates should not stored. Also, any iterable (list like) will be fine to store in GSettings.
  3. It's a matter of taste and preference imo.
  4. is identical to your point in 2.

If this was generated from AI please don't post this to blueman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants