Skip to content

Commit

Permalink
Nits
Browse files Browse the repository at this point in the history
  • Loading branch information
estrattonbailey authored Jan 10, 2025
1 parent e5b1f3c commit 181e8a9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion blog/2025-01-13-typescript-sdk-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ if (isImages(invalidEmbed)) {

The root of the issue here is that the `is*` utility methods perform type casting of objects solely based on the value of their `$type` property. There were basically two ways of fixing this issue:

1. Alter the implementation to actually validate the object's structure. This is a non breaking change that has a big negative impact on performances.
1. Alter the implementation to actually validate the object's structure. This is a non-breaking change that has a negative impact on performance.
2. Alter the function signature to describe what the function actually does. This is a breaking change because TypeScript would start (rightfully) returning lots of errors in places where these functions are used.

Because this release introduces other breaking changes, and because adapting our own code base to this change showed it made more sense, we decided to adopt the latter option.
Expand Down

0 comments on commit 181e8a9

Please sign in to comment.