Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Show blob divert event #33

Merged
merged 3 commits into from
Mar 12, 2024
Merged

✨ Show blob divert event #33

merged 3 commits into from
Mar 12, 2024

Conversation

foysalit
Copy link
Contributor

@foysalit foysalit commented Mar 8, 2024

This is dependent on bluesky-social/atproto#2238

This PR also adjust label SDK usage within ozone-ui to align with latest main on atproto repo.

Copy link

render bot commented Mar 8, 2024

Copy link

render bot commented Mar 8, 2024

}),
)
const selectorOptions = Object.values(ALL_LABELS).map((labelOption) => ({
label: labelOption.identifier,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea what this new type error is?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I assume this is related to @atproto/api updates.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, cleaning it up now. I was referencing a local version of the api package so had to adjust things to get the app to run.

Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't positive about the new handling of labels, but all the divert stuff looks good 👍

@foysalit foysalit force-pushed the divert-blobs branch 2 times, most recently from fc9ab71 to c26ecbb Compare March 12, 2024 15:03
@bnewbold
Copy link
Collaborator

I expected a "Divert" action as an option in the quick-action menu for posts with an image attached, but don't see that in the current render preview?

@foysalit
Copy link
Contributor Author

I expected a "Divert" action as an option in the quick-action menu for posts with an image attached, but don't see that in the current render preview?

ahh classic useEffect bug. pushed out the fix. mind giving it another go @bnewbold ?

@foysalit foysalit merged commit f0ae6cf into main Mar 12, 2024
3 checks passed
@matthieusieben matthieusieben deleted the divert-blobs branch November 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants