-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Show blob divert event #33
Conversation
Your Render PR Server URL is https://ozone-staging-pr-33.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cnlp1d21hbls73f5bq30. |
Your Render PR Server URL is https://ozone-sandbox-pr-33.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cnlp1dq1hbls73f5bq70. |
components/common/labels/Grid.tsx
Outdated
}), | ||
) | ||
const selectorOptions = Object.values(ALL_LABELS).map((labelOption) => ({ | ||
label: labelOption.identifier, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea what this new type error is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I assume this is related to @atproto/api updates.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, cleaning it up now. I was referencing a local version of the api package so had to adjust things to get the app to run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't positive about the new handling of labels, but all the divert stuff looks good 👍
fc9ab71
to
c26ecbb
Compare
I expected a "Divert" action as an option in the quick-action menu for posts with an image attached, but don't see that in the current render preview? |
ahh classic useEffect bug. pushed out the fix. mind giving it another go @bnewbold ? |
This is dependent on bluesky-social/atproto#2238
This PR also adjust label SDK usage within ozone-ui to align with latest
main
on atproto repo.