-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor out bluesky-tiled-plugins
package
#814
base: main
Are you sure you want to change the base?
Conversation
I have registered the |
@@ -0,0 +1,3 @@ | |||
from ._catalog_of_bluesky_runs import CatalogOfBlueskyRuns # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work with entrypoints? I vaguely recall that entrypoints have to point to the actual definition, not an import.
@@ -0,0 +1,17 @@ | |||
# file generated by setuptools_scm | |||
# don't change, don't track in version control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means you, @danielballan.
This creates a second Python package in the databroker repository,
bluesky-tiled-plugins
, with the "special client" objectsBlueskyRun
,BlueskyEventStream
, andCatalogOfBlueskyRuns
, as well as the custom query objectsPartialUID
,ScanID
, andTimeRange
. Quoting the README:This means it is no longer necessary to install
databroker
in the client environment unless they have legacydatabroker.Broker
code.To be clear, the server environment still needs
databroker.mongo_normalized
, the Tiled Adapter for MongoDB with Bluesky document collections.This is a backward-compatible change. Databroker now has a dependency on
bluesky-tiled-plugins
and has shim modules that expose the moved objects at the original locations within thedatabroker
package.Closes #812