-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a fixtures that checks if tasks are still running in tests #538
Conversation
With the additions in the above the modified test correcly failed with:
Now it's been changed. We still need to track down what's causing the |
With the changes to the There seems to be some nasty behavior in tests when devices connected to outside the Lines 98 to 101 in 24c7ccf
|
24c7ccf
to
ff55783
Compare
Currently, detector controller is only disarmed once: ophyd-async/src/ophyd_async/core/_detector.py Lines 202 to 207 in d7f0748
However it is armed in both trigger and prepare: ophyd-async/src/ophyd_async/core/_detector.py Lines 253 to 257 in d7f0748
ophyd-async/src/ophyd_async/core/_detector.py Lines 299 to 303 in d7f0748
This is the cause of all the test failure's here. We should make a seperate issue for it. |
Interestingly, the standard detector unstage error is only present if debug mode is set to true in the |
4959d1d
to
f01f90b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we wait for #542 to be fixed before merging this?
f298fb6
to
e17bcd0
Compare
Discovered a problem with detectors where controllers are armed on prepare and stage, but disarmed only once.
e17bcd0
to
0748db8
Compare
0748db8
to
8f5c4c7
Compare
added autorun fixtures that check if tasks are still running and fail on the test level also corrected some tests with incorrect event-loop usage
Closes #519