-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to copier template 2.3.0 #580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a PR this big I defer to your judgement 😛
The only places which raise an eyebrow somewhat are the slight changes which do actually change functionality (e.g kwargs to args).
I think it's best to merge and clean things up during testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was one method somewhere I found yesterday where a kwarg was converted into an arg. I didn't raise it as a problem... It probably isn't.
src/ophyd_async/sim/demo/_pattern_detector/_pattern_detector.py
Outdated
Show resolved
Hide resolved
* Update to copier template 2.3.0 * Make docs work again, in non-nitpicky mode * Fix ruff errors * Fix end of lines * Support A | B as well as Union[A, B] * Fix remaining tests * Fix pyright issues Fixes #346 * Fix tests on python 3.10 * Review comments * Fix coverage * Fix ruff on sytem tests
Probably unreviewable PR, that adopts the latest copier, bringing: