Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to copier template 2.3.0 #580

Merged
merged 11 commits into from
Sep 18, 2024
Merged

Update to copier template 2.3.0 #580

merged 11 commits into from
Sep 18, 2024

Conversation

coretl
Copy link
Collaborator

@coretl coretl commented Sep 17, 2024

Probably unreviewable PR, that adopts the latest copier, bringing:

Copy link
Contributor

@evalott100 evalott100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a PR this big I defer to your judgement 😛

The only places which raise an eyebrow somewhat are the slight changes which do actually change functionality (e.g kwargs to args).

I think it's best to merge and clean things up during testing.

src/ophyd_async/core/_device_save_loader.py Outdated Show resolved Hide resolved
src/ophyd_async/core/_hdf_dataset.py Show resolved Hide resolved
src/ophyd_async/core/_soft_signal_backend.py Show resolved Hide resolved
Copy link
Contributor

@evalott100 evalott100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was one method somewhere I found yesterday where a kwarg was converted into an arg. I didn't raise it as a problem... It probably isn't.

@coretl coretl merged commit ab11243 into main Sep 18, 2024
32 checks passed
@coretl coretl deleted the typing branch September 18, 2024 11:58
tomtrafford pushed a commit that referenced this pull request Oct 8, 2024
* Update to copier template 2.3.0

* Make docs work again, in non-nitpicky mode

* Fix ruff errors

* Fix end of lines

* Support A | B as well as Union[A, B]

* Fix remaining tests

* Fix pyright issues

Fixes #346

* Fix tests on python 3.10

* Review comments

* Fix coverage

* Fix ruff on sytem tests
@coretl coretl mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Bugbear and pyupgrade linters to ruff
2 participants