Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify ad standard det tests #592

Merged
merged 7 commits into from
Sep 21, 2024
Merged

Simplify ad standard det tests #592

merged 7 commits into from
Sep 21, 2024

Commits on Sep 19, 2024

  1. Refactor ADPilatus tests to use the ad_standard_det_factory

    @jwlodek
    jwlodek committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d328a90 View commit details
    Browse the repository at this point in the history

  2. Add default signals for sim detector config

    @jwlodek
    jwlodek committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8c16042 View commit details
    Browse the repository at this point in the history

  3. Fix type annotation

    @jwlodek
    jwlodek committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1ae69f5 View commit details
    Browse the repository at this point in the history

  4. Overhaul sim detector tests to use ad standard det factory, improve f… 

    …actory with mock put callback
    @jwlodek
    jwlodek committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b7acf91 View commit details
    Browse the repository at this point in the history

  5. Fix tests for remaining detectors to account for new changes to facto… 

    …ry fixture
    @jwlodek
    jwlodek committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    aa98607 View commit details
    Browse the repository at this point in the history

  6. Make sure to include config_sigs passed to init

    @jwlodek
    jwlodek committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c0eae56 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Add suggestions from review

    @jwlodek
    jwlodek committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f196d1a View commit details
    Browse the repository at this point in the history