Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the python package and the config and make the contracts kept #669

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Add the python package and the config and make the contracts kept #669

merged 2 commits into from
Nov 25, 2024

Conversation

stan-dot
Copy link
Contributor

@stan-dot stan-dot commented Nov 22, 2024 •
edited by coretl
Loading

implemented as discussed in the issue description

Fixes #611

@stan-dot stan-dot added enhancement New feature or request design Discussion about the internal design of the repo python Pull requests that update Python code Developer Experience labels Nov 22, 2024
@stan-dot stan-dot requested a review from coretl November 22, 2024 12:27
@stan-dot stan-dot self-assigned this Nov 22, 2024
@stan-dot stan-dot linked an issue Nov 22, 2024 that may be closed by this pull request
Add import-linter #611
Closed
@stan-dot stan-dot marked this pull request as ready for review November 22, 2024 14:29
coretl
coretl requested changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@coretl coretl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is almost there...

.github/workflows/_test.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@stan-dot stan-dot requested a review from coretl November 25, 2024 09:44
@coretl coretl merged commit 235d26a into main Nov 25, 2024
20 checks passed
@coretl coretl deleted the 611-add-import-linter branch November 25, 2024 13:28
evalott100 pushed a commit that referenced this pull request Nov 27, 2024
@stan-dot @evalott100
Add the python package and the config and make the contracts kept (#669)
be3b81f 
* added and all the contracts are kept

* respond to feedback
evalott100 pushed a commit that referenced this pull request Nov 27, 2024
@stan-dot @evalott100
Add the python package and the config and make the contracts kept (#669)
db1746f 
* added and all the contracts are kept

* respond to feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coretl coretl coretl approved these changes

Assignees

@stan-dot stan-dot

Labels
design Discussion about the internal design of the repo Developer Experience enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add import-linter
2 participants
@stan-dot @coretl