-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Create MAINTAINERS.md #1158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recognize every one on the list but wonder what information was used to create this list? I'm looking at https://github.com/bluesky/ophyd/graphs/contributors and some other names with recent commit history. Are these the people who, when asked, agreed to be maintainers?
We decided it in person as a large group of NSLS-II, DLS and LCLS people, using basically the methodology you describe. I appreciate though that some people on the list may feel it's been thrust upon them and I should have been more descriptive in the PR description that this is effectively that request. I'll add everyone on the list as a reviewer and we won't merge until we're all happy. @danielballan maybe we should do the same process for the other We can discuss further on here or mattermost if people have concerns but my understanding was that the role isn't really any additional work above what people are doing anyway and that we wanted to err on the side of lots of people from lots of facilities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 👍 on being a maintainer here
@DominicOram Thanks for your response. I'm just asking so the process becomes documented (resolves any questions in the future). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree to be a maintainer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also ok to be a maintainer 👍
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
This approved PR languishes. Can it be merged now? |
Yes, my understanding is that @klauer is focusing on other projects now with his new (not so new any more) job that's outside the lab/EPICS sphere, though his input would always be valuable and welcome of course. |
Co-authored-by: Zachary Lentz <ZLLentz@users.noreply.github.com>
As discussed in person. This lists the people that are maintainers on ophyd