Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Create MAINTAINERS.md #1158

Merged
merged 3 commits into from
Jun 19, 2024
Merged

DOC: Create MAINTAINERS.md #1158

merged 3 commits into from
Jun 19, 2024

Conversation

DominicOram
Copy link
Contributor

As discussed in person. This lists the people that are maintainers on ophyd

Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recognize every one on the list but wonder what information was used to create this list? I'm looking at https://github.com/bluesky/ophyd/graphs/contributors and some other names with recent commit history. Are these the people who, when asked, agreed to be maintainers?

@DominicOram
Copy link
Contributor Author

We decided it in person as a large group of NSLS-II, DLS and LCLS people, using basically the methodology you describe. I appreciate though that some people on the list may feel it's been thrust upon them and I should have been more descriptive in the PR description that this is effectively that request. I'll add everyone on the list as a reviewer and we won't merge until we're all happy. @danielballan maybe we should do the same process for the other MAINTAINER.md files?

We can discuss further on here or mattermost if people have concerns but my understanding was that the role isn't really any additional work above what people are doing anyway and that we wanted to err on the side of lots of people from lots of facilities.

Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 on being a maintainer here

@prjemian
Copy link
Contributor

@DominicOram Thanks for your response. I'm just asking so the process becomes documented (resolves any questions in the future).

Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to be a maintainer.

Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also ok to be a maintainer 👍

MAINTAINERS.md Outdated Show resolved Hide resolved
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
@prjemian
Copy link
Contributor

This approved PR languishes. Can it be merged now?

@danielballan
Copy link
Member

I think that it was @klauer's intention to step back, and that we should remove him from this list. I hope it goes without saying that future input from Ken would always be more than welcome anywhere in the project.

Maybe @ZLLentz or @tangkong can confirm. With that change, I think we should merge.

@ZLLentz
Copy link
Member

ZLLentz commented Jun 19, 2024

Yes, my understanding is that @klauer is focusing on other projects now with his new (not so new any more) job that's outside the lab/EPICS sphere, though his input would always be valuable and welcome of course.

MAINTAINERS.md Outdated Show resolved Hide resolved
Co-authored-by: Zachary Lentz <ZLLentz@users.noreply.github.com>
@danielballan danielballan merged commit 1f8b64f into master Jun 19, 2024
7 of 10 checks passed
@danielballan danielballan deleted the Update_maintainers branch June 19, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants