-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build mechanism #114
base: master
Are you sure you want to change the base?
Build mechanism #114
Conversation
hi @mcgr0g thanks for the big patch. I might need some time to review it. lol @hms5232 @ziloka @afunTW @vincentinttsh would you like to take a look? |
I notice the develop environment setting set Poetry version 1.3.1, but project pipeline current is 1.1.4. I had made a PR to bump Poetry version in action test (see #115 ). |
Personally, I prefer to keep the repo natural which means any setting for a specific IDE should be set in .gitignore. Let the developer focus on features and bugfix. Or, from another viewpoint, aligning the development setting can boost the community's efficiency. So far, seems the community go on the second option. As long as the testing passed, I am ok with that. |
Kudos, SonarCloud Quality Gate passed! |
I have same thought as afunTW |
I agree |
However after digging through python a bit more (I'm not an experienced python developer). I found it that devcontainers are a bit heavy, and requires developers to install docker. A easier solution is to create a virtual environment via poetry
However I do agree using devcontainers give all developers a easier reproducible environment. |
brought several improvements: