Allow a separate file for modifications to util/dist_prefs #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you work with git and make personal changes to dist_prefs, you might accidentally try to commit those changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is that if you're building in git, you don't want to modify
util/dist_prefs, otherwise you'll be potentially pushing your local modifications. The idea is to source a file afterutil/dist_prefs. This patch gives two options for accomplishing this:util/user_prefs.BMAD_USER_PREFSwhich is the full path to a file with user preferences.The former is a simpler option for someone just building in a single tree. The latter is nicer for someone (like me) who's maybe using
worktreeto build releases while maintaining a development tree. As written, if both are present it will do both (2 then 1), though that is not the usage I would expect.