check for existing data before radiation_map_setup #532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the performance issue in #523. I think I was able to solve it by putting a check before where the
radiation_map_setup
subroutine is called.Here is the performance on the example in the issue before the change.
Here is the performance with the checks.
It gives about a 25% reduction in running time for this example. Profiling it after the change confirms that the
radiation_map_setup
code takes an insignificant amount of time.