Fixed FAQ link in README.md and refactored two strings to strings.xml (…

…#47) * Update README.md Fixed FAQ link * Moved strings to strings.xml
bmax121 · Jan 6, 2024 · 6e745a5 · 6e745a5
1 parent 1b5a26d
commit 6e745a5
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -38,7 +38,7 @@ To help translate APatch or improve existing translations, please use [Weblate](
 
 ## More Information
 
-- [FAQ](doc/en/faq.md)
+- [FAQ](docs/en/faq.md)
 
 ## Credits
 

diff --git a/app/src/main/java/me/bmax/apatch/ui/screen/APM.kt b/app/src/main/java/me/bmax/apatch/ui/screen/APM.kt
@@ -65,7 +65,7 @@ fun APModuleScreen(navigator: DestinationsNavigator) {
             horizontalAlignment = Alignment.CenterHorizontally) {
             Row {
                 Text(
-                    text = "Android Patch Not Installed",
+                    text = stringResource(id = R.string.apm_not_installed),
                     style = MaterialTheme.typography.titleMedium
                 )
             }

diff --git a/app/src/main/java/me/bmax/apatch/ui/screen/Home.kt b/app/src/main/java/me/bmax/apatch/ui/screen/Home.kt
@@ -280,7 +280,15 @@ fun FloatButton(navigator: DestinationsNavigator) {
                     }
                 },
                 icon = { Icon(Icons.Filled.Key, "") },
-                text = { Text(text = if(state != APApplication.State.UNKNOWN_STATE) "Clear Key" else "SuperKey" )},
+                text = {
+                    Text(
+                        text = if (state != APApplication.State.UNKNOWN_STATE) {
+                            stringResource(id = R.string.clear_super_key)
+                        } else {
+                            stringResource(id = R.string.super_key)
+                        }
+                    )
+                },
             )
         }
     }

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -25,6 +25,7 @@
     <string name="safe_mode">Safe mode</string>
 
     <string name="super_key">SuperKey</string>
+    <string name="clear_super_key">Clear Key</string>
     <string name="home_patch_set_key_title">Set SuperKey</string>
     <string name="home_patch_set_key_desc">Only credential for KernelPatch</string>
     <string name="home_patch_next_step">Next Step</string>
@@ -86,6 +87,7 @@
     <string name="su_refresh">Refresh</string>
 
     <string name="apm">APModule</string>
+    <string name="apm_not_installed">Android Patch Not Installed</string>
     <string name="apm_failed_to_enable">Failed to enable module: %s</string>
     <string name="apm_failed_to_disable">Failed to disable module: %s</string>
     <string name="apm_empty">No module installed</string>