Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Home): add state icons #62

Merged
merged 1 commit into from
Jan 10, 2024
Merged

feat(Home): add state icons #62

merged 1 commit into from
Jan 10, 2024

Conversation

ponces
Copy link
Contributor

@ponces ponces commented Jan 8, 2024

No description provided.

@bmax121
Copy link
Owner

bmax121 commented Jan 9, 2024

Do you have any screenshots of the state icons

@ponces
Copy link
Contributor Author

ponces commented Jan 9, 2024

Do you have any screenshots of the state icons

Yeah! They are pretty similar to what KernelSU has but I can adjust them if you prefer any other preference :)

Not installed

_295166007-698ddfa8-5c4f-40c1-95ce-c16bc91f7ede

Updating

_295166942-1bbee1b2-5a23-4779-b1b3-fdf6a9e93aff

Working

_295166008-122bdc0f-a6e3-4e71-a4de-d2f731d71619

@ponces
Copy link
Contributor Author

ponces commented Jan 9, 2024

any change needed?

@marat2509
Copy link
Collaborator

any change needed?

Is it possible to add minimal animation for these icons? At least appearances/changes, otherwise they change soullessly

@ponces
Copy link
Contributor Author

ponces commented Jan 9, 2024

any change needed?

Is it possible to add minimal animation for these icons? At least appearances/changes, otherwise they change soullessly

I would say it's a bit out of scope of this PR but I can take a look at it after this is merged, yeah

@bmax121 bmax121 merged commit aba079e into bmax121:main Jan 10, 2024
2 checks passed
@ponces ponces deleted the main-add-state-icons branch January 10, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants