API access (hidden) to disable moment map server-side saving (spacete…

…lescope#2469)

* optionally disable moment map server-side saving

jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.py

@@ -50,6 +50,11 @@ class MomentMap(PluginTemplateMixin, DatasetSelectMixin, SpectralSubsetSelectMix
     moment_available = Bool(False).tag(sync=True)
     overwrite_warn = Bool(False).tag(sync=True)
 
+    # export_enabled controls whether saving the moment map to a file is enabled via the UI.  This
+    # is a temporary measure to allow server-installations to disable saving server-side until
+    # saving client-side is supported
+    export_enabled = Bool(True).tag(sync=True)
+
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
@@ -58,6 +63,11 @@ def __init__(self, *args, **kwargs):
         self.dataset.add_filter('is_cube')
         self.add_results.viewer.filters = ['is_image_viewer']
 
+        if self.app.state.settings.get('server_is_remote', False):
+            # when the server is remote, saving the file in python would save on the server, not
+            # on the user's machine, so export support in cubeviz should be disabled
+            self.export_enabled = False
+
     @property
     def _default_image_viewer_reference_name(self):
         return self.jdaviz_helper._default_image_viewer_reference_name
@@ -138,6 +148,10 @@ def vue_overwrite_fits(self, *args):
     def _write_moment_to_fits(self, overwrite=False, *args):
         if self.moment is None or not self.filename:  # pragma: no cover
             return
+        if not self.export_enabled:
+            # this should never be triggered since this is intended for UI-disabling and the
+            # UI section is hidden, but would prevent any JS-hacking
+            raise ValueError("Writing out moment map to file is currently disabled")
 
         # Make sure file does not end up in weird places in standalone mode.
         path = os.path.dirname(self.filename)

jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.vue

@@ -49,11 +49,11 @@
       @click:action="calculate_moment"
     ></plugin-add-results>
 
-    <j-plugin-section-header>Results</j-plugin-section-header>
+    <j-plugin-section-header v-if="export_enabled">Results</j-plugin-section-header>
 
     <div style="display: grid; position: relative"> <!-- overlay container -->
       <div style="grid-area: 1/1">
-        <div v-if="moment_available">
+        <div v-if="moment_available && export_enabled">
           <v-row>
               <v-text-field
               v-model="filename"
@@ -77,7 +77,7 @@
       <v-overlay
         absolute
         opacity=1.0
-        :value="overwrite_warn"
+        :value="overwrite_warn && export_enabled"
         :zIndex=3
         style="grid-area: 1/1; 
                margin-left: -24px;

jdaviz/configs/cubeviz/plugins/tests/test_cubeviz_helper.py

@@ -73,7 +73,7 @@ def test_valid_function(cubeviz_helper, spectrum1d_cube):
     assert cubeviz_helper.specviz.get_data(data_label="test[FLUX]").flux.ndim == 1
 
 
-def test_remote_server_disable_movie():
+def test_remote_server_disable_save_serverside():
     config = get_configuration('cubeviz')
     config['settings']['server_is_remote'] = True
 
@@ -82,6 +82,9 @@ def test_remote_server_disable_movie():
     ep = cubeviz_helper.plugins['Export Plot']
     assert ep._obj.movie_enabled is False
 
+    mm = cubeviz_helper.plugins['Moment Maps']
+    assert mm._obj.export_enabled is False
+
 
 def test_get_data_spatial_and_spectral(cubeviz_helper, spectrum1d_cube_larger):
     data_label = "test"