Add restart feature #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No test were added, USAGE.md wasn't updated. If needed I can update PR with those or anything else needed. |
fpankretic
had a problem deploying
to
testpypi
GitHub Actions
Failure
bmwant
requested changes
Sep 30, 2024
| @@ -340,3 +357,17 @@ def signal(self, hap: Hap, sig: signal.Signals): | |||
| f"{config.ICON_INFO} Cannot send signal to the inactive hap", | |||
| style=f"{config.COLOR_ERROR} bold", | |||
| ) | |||
|
|
|||
| def restart(self, hap: Hap): | |||
| hid, name, cmd = hap.hid, hap.name, hap.cmd | |||
There was a problem hiding this comment.
maybe name should contain -restarted suffix or something to have some hint for the user? wdyt
There was a problem hiding this comment.
Hmm, I would maybe personally prefer it without a suffix. If needed, some flag like --suffix or --no-suffix can be added.
|
@fpankretic thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35