Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEP-441: Implement EIP-7702: Set EOA account code #2724

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Sep 27, 2024

Description

BEP-441: Implement EIP-7702: Set EOA account code

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

code is following ethereum/go-ethereum#30078

As said in (ethereum/go-ethereum#30519) , https://github.com/lightclient/go-ethereum/tree/prague-devnet-3 is is used for Pectra-devnet-3

in the prague upgrade, eip-7702 is the most complicated, and the spec still not be finalized.
according to https://notes.ethereum.org/@ethpandaops/pectra-devnet-3
run pectra-devnet-3@v1.5.0 against ethereum/go-ethereum#30078, still have many failed test cases 93/1596.

but after picking the code into bsc, there are 145/1596 failed cases.
by debugging, I find the reason, ethereum/go-ethereum#29520
but this PR is not easy to pick, so I do code implement after understanding it, outcome the second commit, please review it carefully! Now the number of passed test cases is 93/1596 too.

@buddh0 buddh0 force-pushed the set_EOA_account_code branch 2 times, most recently from 6fb5abb to ca11f37 Compare September 27, 2024 05:59
Co-authored-by: lightclient <lightclient@protonmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
@buddh0
Copy link
Collaborator Author

buddh0 commented Sep 27, 2024

please reserve all commits when merging into develop!

@buddh0 buddh0 marked this pull request as ready for review September 27, 2024 12:03
@Kya123iu
Copy link

Kya123iu commented Oct 1, 2024

please reserve all commits when merging into develop!

soeng.ll060@gmail.com

@Kya123iu
Copy link

Kya123iu commented Oct 1, 2024

5pwMH5Tjcj-Pg-yy345

@Kya123iu
Copy link

Kya123iu commented Oct 1, 2024

soeng.ll060@gmail.com> please reserve all commits when merging into develop!

@Kya123iu
Copy link

Kya123iu commented Oct 1, 2024

Description

BEP-441: Implement EIP-7702: Set EOA account code

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

code is following ethereum/go-ethereum#30078

but I can't find which version or commit of geth is used for Pectra-devnet-3, and have rise a question to go-ethereum teams.

in the prague upgrade, eip-7702 is the most complicated, and the spec still not be finalized.
according to https://notes.ethereum.org/@ethpandaops/pectra-devnet-3
run pectra-devnet-3@v1.5.0 against ethereum/go-ethereum#30078, still have many failed test cases 93/1596.

but after picking the code into bsc, there are 145/1596 failed cases.
by debugging, I find the reason, ethereum/go-ethereum#29520
but this PR is not easy to pick, so I do code implement after understanding it, outcome the second commit, please review it carefully! Now the number of passed test cases is 93/1596 too.

Copy link

@octavio12345300 octavio12345300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listo

@Kya123iu
Copy link

Kya123iu commented Oct 3, 2024

Description.060331123

BEP-441: Implement EIP-7702: Set EOA account code

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

code is following ethereum/go-ethereum#30078

but I can't find which version or commit of geth is used for Pectra-devnet-3, and have rise a question to go-ethereum teams.

in the prague upgrade, eip-7702 is the most complicated, and the spec still not be finalized.
according to https://notes.ethereum.org/@ethpandaops/pectra-devnet-3
run pectra-devnet-3@v1.5.0 against ethereum/go-ethereum#30078, still have many failed test cases 93/1596.

but after picking the code into bsc, there are 145/1596 failed cases.
by debugging, I find the reason, ethereum/go-ethereum#29520
but this PR is not easy to pick, so I do code implement after understanding it, outcome the second commit, please review it carefully! Now the number of passed test cases is 93/1596 too.

@Kya123iu
Copy link

Kya123iu commented Oct 3, 2024

060331123

BEP-441: Implement EIP-7702: Set EOA account code

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

code is following ethereum/go-ethereum#30078

but I can't find which version or commit of geth is used for Pectra-devnet-3, and have rise a question to go-ethereum teams.

in the prague upgrade, eip-7702 is the most complicated, and the spec still not be finalized.
according to https://notes.ethereum.org/@ethpandaops/pectra-devnet-3
run pectra-devnet-3@v1.5.0 against ethereum/go-ethereum#30078, still have many failed test cases 93/1596.

but after picking the code into bsc, there are 145/1596 failed cases.
by debugging, I find the reason, ethereum/go-ethereum#29520
but this PR is not easy to pick, so I do code implement after understanding it, outcome the second commit, please review it carefully! Now the number of passed test cases is 93/1596 too.

@Kya123iu
Copy link

Kya123iu commented Oct 3, 2024

060331123

BEP-441: Implement EIP-7702: Set EOA account code

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

code is following ethereum/go-ethereum#30078

but I can't find which version or commit of geth is used for Pectra-devnet-3, and have rise a question to go-ethereum teams.

in the prague upgrade, eip-7702 is the most complicated, and the spec still not be finalized.
according to https://notes.ethereum.org/@ethpandaops/pectra-devnet-3
run pectra-devnet-3@v1.5.0 against ethereum/go-ethereum#30078, still have many failed test cases 93/1596.

but after picking the code into bsc, there are 145/1596 failed cases.
by debugging, I find the reason, ethereum/go-ethereum#29520
but this PR is not easy to pick, so I do code implement after understanding it, outcome the second commit, please review it carefully! Now the number of passed test cases is 93/1596 too.

@Kya123iu
Copy link

Kya123iu commented Oct 3, 2024

Description

[BEP-441: Implement EIP-7702: Set EOA account code ](https://github.com/bnb-chain/BEPs/pull/060331123

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

code is following ethereum/go-ethereum#30078

but I can't find which version or commit of geth is used for Pectra-devnet-3, and have rise a question to go-ethereum teams.

in the prague upgrade, eip-7702 is the most complicated, and the spec still not be finalized.
according to https://notes.ethereum.org/@ethpandaops/pectra-devnet-3
run pectra-devnet-3@v1.5.0 against ethereum/go-ethereum#30078, still have many failed test cases 93/1596.

but after picking the code into bsc, there are 145/1596 failed cases.
by debugging, I find the reason, ethereum/go-ethereum#29520
but this PR is not easy to pick, so I do code implement after understanding it, outcome the second commit, please review it carefully! Now the number of passed test cases is 93/1596 too.

@Kya123iu
Copy link

Kya123iu commented Oct 3, 2024

Description

BEP-441: Implement EIP-7702: Set EOA account code 060331123

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

code is following ethereum/go-ethereum#30078

but I can't find which version or commit of geth is used for Pectra-devnet-3, and have rise a question to go-ethereum teams.

in the prague upgrade, eip-7702 is the most complicated, and the spec still not be finalized.
according to https://notes.ethereum.org/@ethpandaops/pectra-devnet-3
run pectra-devnet-3@v1.5.0 against ethereum/go-ethereum#30078, still have many failed test cases 93/1596.

but after picking the code into bsc, there are 145/1596 failed cases.
by debugging, I find the reason, ethereum/go-ethereum#29520
but this PR is not easy to pick, so I do code implement after understanding it, outcome the second commit, please review it carefully! Now the number of passed test cases is 93/1596 too.

@Kya123iu
Copy link

Kya123iu commented Oct 3, 2024

Description

BEP-441: Implement EIP-7702: Set EOA account code

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

code is following ethereum/go-ethereum#30078

but I can't find which version or commit of geth is used for Pectra-devnet-3, and have rise a question to go-ethereum teams.

in the prague upgrade, eip-7702 is the most complicated, and the spec still not be finalized.
according to https://notes.ethereum.org/@ethpandaops/pectra-devnet-3
run pectra-devnet-3@v1.5.0 against ethereum/go-ethereum#30078, still have many failed test cases 93/1596.

but after picking the code into bsc, there are 145/1596 failed cases.
by debugging, I find the reason, ethereum/go-ethereum#29520
but this PR is not easy to pick, so I do code implement after understanding it, outcome the second commit, please review it carefully! Now the number of passed test cases is 93/1596 too.

069331123

Copy link

@Kya123iu Kya123iu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buddh0
Copy link
Collaborator Author

buddh0 commented Oct 10, 2024

convert to draft, wait the final spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants