Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry-picked from upstream code #109

Merged
merged 1 commit into from
May 14, 2024

Conversation

welkin22
Copy link
Contributor

Description

When we merged version 1.7.2 of the upstream code for opbnb into our repository, this PR was missing from the content of the op-geth version it depends on. This PR was submitted in v1.101308.3, but our op-geth repository only merged the code from upstream v1.101308.2.
This PR has no impact on the block production logic, only affects the CI of the opbnb repository and the code in op-program, so there is no need for urgent repair. This is a change made to fix the CI of the opbnb repository.

Rationale

This PR is cherry-picked from upstream code in order to fix the CI of the opbnb repository.

Example

none

Changes

Notable changes:

  • cherry-picked upstream code
  • ...

Will allow the override to optionally delegate some functions to the original precompile instead of having to fully replace it.
@welkin22 welkin22 changed the title Pass the original precompile to the override function. fix: cherry-picked from upstream code May 11, 2024
Copy link
Contributor

@redhdx redhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@aweneagle aweneagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andyzhang2023 andyzhang2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@welkin22 welkin22 merged commit f8d1c9e into bnb-chain:develop May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants