perf: speedup pbss trienode read #122
Merged
+244
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-2012
changed the title
rm086
approved these changes
Jun 19, 2024
will-2012
force-pushed
the
add-pbss-cache
branch
2 times, most recently
from
c7849cc
to
cc484b6
Compare
will-2012
force-pushed
the
add-pbss-cache
branch
from
cc484b6
to
cd88da0
Compare
krish-nr
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
LGTM
After discussing with the author, this optimized PR was picked from BSC and includes additional logic from OP, but it does not affect the main process. The intention is to flatten the 128-layer diff layer query into a k-v cache to reduce memory read times.
joeylichang
approved these changes
Jul 4, 2024
andyzhang2023
pushed a commit
that referenced
this pull request
Aug 9, 2024
Co-authored-by: will@2012 <xibaow2020@qq.com>
andyzhang2023
pushed a commit
to andyzhang2023/op-geth
that referenced
this pull request
Sep 11, 2024
Co-authored-by: will@2012 <xibaow2020@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick from bsc, bnb-chain/bsc#2508.
Rationale
Refer to cherry-pick PR.
Example
N/A.
Changes
Notable changes: