txDAG transfer by gasless transaction (#28) #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* txDAG transfer * encode/decode txDAG data with ABI * set txDAG receiver to a special address --------- Co-authored-by: andyzhang2023 <andyzhang2023@gmail.com> merge conflict fix conflict
galaio
reviewed
Aug 26, 2024
added 2 commits
August 27, 2024 16:18
…tions are executed
…tions are executed
galaio
reviewed
Aug 28, 2024
miner/worker.go
Outdated
| @@ -1167,6 +1246,8 @@ func (w *worker) fillTransactions(interrupt *atomic.Int32, env *environment) err | |||
| return err | |||
| } | |||
| } | |||
| // append a DAG tx at the end of the block | |||
| w.appendTxDAG(env) | |||
There was a problem hiding this comment.
If there has MEV bundles, this tx may not the last one?
galaio
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
txDAG transfer
encode/decode txDAG data with ABI
set txDAG receiver to a special address
Co-authored-by: andyzhang2023 andyzhang2023@gmail.com
merge conflict
fix conflict
Description
add a description of your changes here...
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: