Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse big.Int objects for GC optimization #172

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Reuse big.Int objects for GC optimization #172

wants to merge 7 commits into from

Conversation

andyzhang2023
Copy link
Contributor

Description

Reuse the big.Int objects on the "hot path", to decrease the GC pressure.
The key functions are:

  1. effectiveGasTipValue()
  2. Transaction.Cost()
  3. newL1CostFuncEcotone()
  4. SubmitTransaction API
  5. buyGas()

It's notable that the function effectiveGasTipValue() might not be a "hot path" anymore after the "reheap optimization".

@andyzhang2023 andyzhang2023 changed the base branch from main to develop September 11, 2024 02:49
welkin22
welkin22 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyzhang2023 andyzhang2023 marked this pull request as draft October 8, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welkin22 welkin22 welkin22 approved these changes

@owen-reorg owen-reorg Awaiting requested review from owen-reorg

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhang2023 @welkin22 @owen-reorg