optimization: enqueue transactions in parallel from p2p #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoieh
approved these changes
Sep 19, 2024
owen-reorg
approved these changes
Oct 10, 2024
owen-reorg
changed the title
owen-reorg
added a commit
that referenced
this pull request
Oct 14, 2024
Co-authored-by: Owen <103096885+owen-reorg@users.noreply.github.com> Co-authored-by: andyzhang2023 <andyzhang2023@gmail.com>
This was referenced Oct 14, 2024
welkin22
added a commit
to welkin22/op-geth
that referenced
this pull request
Oct 28, 2024
…chain#173)" This reverts commit 593869d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enqueuing a transaction into the txpool, it costs about 80us per transaction to call
txpool.Add(tx), within which thetxpool.addLocked(tx)costs only 15us.So by calling
txpool.Add(tx)in parallel, we can improve the performance oftxpool.Add(tx)from 12KTPS to 60KTPS:It helps a lot when the traffic is heavy and a lot of transactions are accumulated in the broadcasting caches, like "p2p buffers", TCP read buffer and TCP write buffers.