pevm: unordered merge mode flag #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welkin22
requested review from
sunny2022da and
andyzhang2023
and removed request for
owen-reorg and
bnoieh
sunny2022da
reviewed
Oct 22, 2024
| } | ||
| //if err := pst.conflictsToMaindb(); err != nil { | ||
| // return err | ||
| //} |
There was a problem hiding this comment.
we can keep this uncommented, and make separate PR later for this when it is confirmed to be OK
welkin22
added a commit
that referenced
this pull request
Oct 22, 2024
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an unordered merge mode and include a flag to enable it.
Rationale
In the confirm phase of PEVM, we fully trust the txDAG. The advantage of this is that we can skip conflict checks and immediately merge the execution results into the statedb after executing transactions at each txlevel. This will achieve better performance.
Example
--parallel.unordered-merge
Changes
Notable changes: