Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: tstorage revert and selfdestruct6780 revert #206

Conversation

andyzhang2023
Copy link
Contributor

Description

The case of go test -run TestExecutionSpecBlocktests failed when run in tests dir. It said: invalid gas used and invalid mercle root.

Rationale

There are two bugs which caused these:

  1. The pre-value is incorrect when adding journal for TransientStorage. It should be the previous one, but not the current one.
  2. The op SelfDestruct6780 forgot to add its journal for revert. It should call SelfDestruct() to do it.

Copy link
Collaborator

@sunny2022da sunny2022da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyzhang2023 andyzhang2023 merged commit d58b8e0 into bnb-chain:feature/TxDAG-PEVM Oct 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants