Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/pevm oom #210

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fix/pevm oom #210

merged 2 commits into from
Nov 1, 2024

Conversation

andyzhang2023
Copy link
Contributor

@andyzhang2023 andyzhang2023 commented Oct 31, 2024 •
edited
Loading

Description

There is an oom issue in transaction pool caused by reheap optimization:

  1. The demoted transactions would not be removed unless the pool is full, which means those staled transactions will stay in the priced list forever until the pool overflows.
  2. memory grows too fast if the pool copy all transactions 5 times per second, so we reduce it to 1 time per second.

sunny2022da
sunny2022da reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@sunny2022da sunny2022da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，suggested to submit to develop branch and PEVM can cherry-pick.

@sunny2022da sunny2022da merged commit 52ac556 into bnb-chain:feature/TxDAG-PEVM Nov 1, 2024
1 of 2 checks passed
sunny2022da pushed a commit to sunny2022da/op-geth that referenced this pull request Nov 3, 2024
@andyzhang2023 @sunny2022da
Fix/pevm oom (bnb-chain#210)
bf98242 
Co-authored-by: andyzhang2023 <andyzhang2023@gmail.com>
sunny2022da pushed a commit to sunny2022da/op-geth that referenced this pull request Nov 14, 2024
@andyzhang2023 @sunny2022da
Fix/pevm oom (bnb-chain#210)
2d43a3c 
Co-authored-by: andyzhang2023 <andyzhang2023@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunny2022da sunny2022da sunny2022da left review comments

@owen-reorg owen-reorg Awaiting requested review from owen-reorg

@welkin22 welkin22 Awaiting requested review from welkin22

Assignees
No one assigned
Labels
pevm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyzhang2023 @sunny2022da