Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: txpool reheap oom #211

Merged
merged 9 commits into from
Nov 26, 2024
Merged

bugfix: txpool reheap oom #211

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
08685aa
fix:staled transactions will lead to oom if the pool is always not-empty
Oct 30, 2024
a648aaf
fix: memory grows too fast if the pool copy all transactions 5 times …
Oct 30, 2024
9977997
Merge branch 'develop' into fix/txpool-reheap-oom
owen-reorg Nov 23, 2024
8582cd0
adjust sync2cache from 200s to 1.5s, for passing the Unit test cases
Nov 25, 2024
6d62d4d
Merge branch 'fix/txpool-reheap-oom' of andyzhang2023.github.com:andy…
Nov 25, 2024
28fb189
adjust sync2cache from 200s to 1.5s, for passing the Unit test cases
Nov 25, 2024
4d600de
Revert "adjust sync2cache from 200s to 1.5s, for passing the Unit tes…
Nov 25, 2024
afabfd5
Revert "adjust sync2cache from 200s to 1.5s, for passing the Unit tes…
Nov 25, 2024
7893787
set sync2cache frequency from 200s to 400ms, to pass the unit cases
Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/txpool/legacypool/legacypool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ func (pool *LegacyPool) Init(gasTip uint64, head *types.Header, reserve txpool.A
}

func (pool *LegacyPool) loopOfSync() {
ticker := time.NewTicker(200 * time.Millisecond)
ticker := time.NewTicker(400 * time.Millisecond)
for {
select {
case <-pool.reorgShutdownCh:
Expand Down Expand Up @@ -1892,6 +1892,7 @@ func (pool *LegacyPool) demoteUnexecutables(demoteAddrs []common.Address) {
}
demoteTxMeter.Mark(int64(len(demoteAddrs)))

var removed = 0
// Iterate over all accounts and demote any non-executable transactions
gasLimit := txpool.EffectiveGasLimit(pool.chainconfig, pool.currentHead.Load().GasLimit, pool.config.EffectiveGasCeil)
for _, addr := range demoteAddrs {
Expand Down Expand Up @@ -1955,7 +1956,9 @@ func (pool *LegacyPool) demoteUnexecutables(demoteAddrs []common.Address) {
}
}
pool.pendingCache.del(dropPendingCache, pool.signer)
removed += len(dropPendingCache)
}
pool.priced.Removed(removed)
}

// addressByHeartbeat is an account address tagged with its last activity timestamp.
Expand Down
Loading