Merge pull request #221 from figo/master

BuildJob accept map as argument rather than a slice
bndr · Jan 12, 2021 · ab81397 · ab81397
2 parents 980672b + 27e7500
commit ab81397
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -45,7 +45,7 @@ if err != nil {
   panic("Something Went Wrong")
 }
 
-queueid, err := jenkins.BuildJob(ctx, "#jobname")
+queueid, err := jenkins.BuildJob(ctx, "#jobname", nil)
 if err != nil {
   panic(err)
 }

diff --git a/jenkins.go b/jenkins.go
@@ -267,12 +267,8 @@ func (j *Jenkins) DeleteJob(ctx context.Context, name string) (bool, error) {
 // Invoke a job.
 // First parameter job name, second parameter is optional Build parameters.
 // Returns queue id
-func (j *Jenkins) BuildJob(ctx context.Context, name string, options ...interface{}) (int64, error) {
+func (j *Jenkins) BuildJob(ctx context.Context, name string, params map[string]string) (int64, error) {
 	job := Job{Jenkins: j, Raw: new(JobResponse), Base: "/job/" + name}
-	var params map[string]string
-	if len(options) > 0 {
-		params, _ = options[0].(map[string]string)
-	}
 	return job.InvokeSimple(ctx, params)
 }