refactoring #114
Merged
refactoring #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlehYakovenko
approved these changes
Dec 1, 2023
hladchenko
approved these changes
Dec 1, 2023
golichenko02
reviewed
Dec 1, 2023
| * Implementation of the {@link ObjectFactory} as Bring beans container. Creates and holds all found | ||
| * and registered beans. | ||
| * Implementation of the {@link ObjectFactory} as Bring beans container. Creates and holds all | ||
| * founded and registered beans. |
There was a problem hiding this comment.
‘Found’ is a second form, -ed redundant
golichenko02
reviewed
Dec 1, 2023
| @@ -74,7 +75,8 @@ public static BringContainer run(Class<?> configClass) { | |||
|
|
|||
| TomcatServer.run(container); | |||
| log.info("BringContainer initialized successfully."); | |||
| log.debug("All created beans:%n%s".formatted(container.storageByName.keySet().stream().reduce("", (s1,s2) -> s1 + System.lineSeparator() + s2))); | |||
| log.debug("All created beans:%n%s".formatted(container.storageByName.keySet().stream() | |||
There was a problem hiding this comment.
It’s better to use {} for logger instead of string formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.