Fix PR #346 comments #367
Merged
Fix PR #346 comments #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
LarsSelbekk
commented
Aug 25, 2023
LarsSelbekk
commented
- feat(MatchDetail): improve error message
- feat(MatchDetail): link branch hours in StandMatch
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This fixes comments of #346. Note for opening hours linking: we don't store which branch a stand match belongs to, so it's not possible to link directly to the opening hours for a specific branch without API changes. It now links to the opening hours branch selector, which if you've already chosen a branch redirects to that branch. This might be okay, but it might also be error-prone if someone has chosen the wrong branch. Also, I couldn't find a branch that actually had opening hours 🤷♂️ |
4 failed tests on run #159 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Settings page > displays correct inital elements |
Output
Screenshots
Video
|
|
forgot.spec.js • 1 failed test • UI - Electron
| Test | Artifacts | |
|---|---|---|
| Forgot password > can navigate to and from forgot page |
Output
Screenshots
Video
|
|
login.spec.js • 1 failed test • UI - Electron
| Test | Artifacts | |
|---|---|---|
| Login > displays all important elements |
Output
Screenshots
Video
|
|
register.spec.js • 1 failed test • UI - Electron
| Test | Artifacts | |
|---|---|---|
| Register > displays correct initial elements |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.