Improve nested info tabs #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
LarsSelbekk
commented
Aug 29, 2023
LarsSelbekk
commented
- fix(DynamicLink): missing ref console error
- feat(theme): update mui viewport breakpoints
- fix(theme): add padding for native select
- feat(info): make sub-tabs more distinct looking
Somewhat smaller sizes made sense for our mobile-first page.
On e.g. Windows, the text was right up against the left edge.
The info page /info/policies/* have two layers of tabs, which should be more distinct looking to easily distinguish the two layers. This commit fixes that by making the sub-tab selector a button group.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LarsSelbekk
force-pushed
the
improve-nested-info-tabs
branch
from
435dbbc
to
0b9ed1f
Compare
|
|
7 failed tests on run #165 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Settings page > displays correct inital elements |
Output
Screenshots
Video
|
|
forgot.spec.js • 1 failed test • UI - Electron
| Test | Artifacts | |
|---|---|---|
| Forgot password > can navigate to and from forgot page |
Output
Screenshots
Video
|
|
login.spec.js • 1 failed test • UI - Electron
| Test | Artifacts | |
|---|---|---|
| Login > displays all important elements |
Output
Screenshots
Video
|
|
register.spec.js • 1 failed test • UI - Electron
| Test | Artifacts | |
|---|---|---|
| Register > displays correct initial elements |
Output
Screenshots
Video
|
|
info.spec.js • 3 failed tests • UI - Electron
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.