-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Scanner #430
Improve Scanner #430
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
e2ba737
to
2151ebb
Compare
2151ebb
to
c624346
Compare
c624346
to
cf7e208
Compare
cf7e208
to
4e214f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a book is successfully scanned, we may need to close the scanner/replace it with another modal - it's currently very very easy to re-scan an already scanned book. Also, when you scan a book you have already scanned, the banner should be green. Finally, I think the vibration should only happen if the scan is successful, so we don't get the machine-gun-fire vibration we do currently.
8e2be5a
to
7fac96c
Compare
Partially fixed, the scanner now closes upon successful scan, but I still think the alerts should be bigger. Created a separate Trello card for this: https://trello.com/c/iZlKgRg7
This is a bug, moving this to a separate PR based on this Trello card: https://trello.com/c/QGrlyIRm
✅ |
No description provided.