Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Scanner #430

Merged
merged 6 commits into from
May 30, 2024
Merged

Improve Scanner #430

merged 6 commits into from
May 30, 2024

Conversation

AdrianAndersen
Copy link
Member

No description provided.

@AdrianAndersen AdrianAndersen self-assigned this Apr 30, 2024
Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bl-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 1:40pm

@AdrianAndersen
Copy link
Member Author

Copy link
Member

@LarsSelbekk LarsSelbekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a book is successfully scanned, we may need to close the scanner/replace it with another modal - it's currently very very easy to re-scan an already scanned book. Also, when you scan a book you have already scanned, the banner should be green. Finally, I think the vibration should only happen if the scan is successful, so we don't get the machine-gun-fire vibration we do currently.

@AdrianAndersen
Copy link
Member Author

@AdrianAndersen
Copy link
Member Author

When a book is successfully scanned, we may need to close the scanner/replace it with another modal - it's currently very very easy to re-scan an already scanned book.

Partially fixed, the scanner now closes upon successful scan, but I still think the alerts should be bigger. Created a separate Trello card for this: https://trello.com/c/iZlKgRg7

Also, when you scan a book you have already scanned, the banner should be green.

This is a bug, moving this to a separate PR based on this Trello card: https://trello.com/c/QGrlyIRm

Finally, I think the vibration should only happen if the scan is successful, so we don't get the machine-gun-fire vibration we do currently.

@AdrianAndersen AdrianAndersen merged commit 7570625 into main May 30, 2024
8 checks passed
@AdrianAndersen AdrianAndersen deleted the improve-scanner branch May 30, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants