feat(match): stricter sender-fulfilled-calculation #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the item/match fulfilled calculcation stricter for the sender by requiring them to both have their book delivered to someone, but also that their match receives a copy of the book. This prevents people from thinking they're finished if they've swapped books with someone else, and that person has delivered their books. Now, they will still see that they need to give away those books to the intended recipient.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AdrianAndersen
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the item/match fulfilled calculcation stricter for the sender by
requiring them to both have their book delivered to someone, but also
that their match receives a copy of the book. This prevents people from
thinking they're finished if they've swapped books with someone else,
and that person has delivered their books. Now, they will still see that
they need to give away those books to the intended recipient.
Also updated the message the sender sees in that case, moved the warning below the progress bar and tweaked some margins.
