bl next linking #400
Merged
bl next linking #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LarsSelbekk
requested changes
Jul 23, 2023
There was a problem hiding this comment.
Looks mostly good. I'm just going to comment in this one since these PRs concern the same thing. The linking looks mostly fine, but I'm not sure the bl-next info page is at parity with the old one.
- For skolekunder: "Under finner du en liste over brukte skolebøker" - no list beneath
- For VGS-elever: different schools mentioned
In addition, trying to log out from bl-next doesn't log out from bl-web and sends you back there, so when you return to bl-next you're logged in again.
AdrianAndersen
force-pushed
the
bl-next-linking
branch
from
965085e
to
b856a4c
Compare
|
I have addressed your concerns now @LarsSelbekk. Please check out this and the corresponding PR for bl-web 😄 |
LarsSelbekk
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we use bl-next /info page in place of the bl-web/info. To enable this, we transfer tokens back and forth between bl-web and bl-next
Depends on:
boklisten/bl-next#351
Branched out from:
#399