Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional REL flag parsing, fixed PVT carr_soln parsing #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m-elias
Copy link

@m-elias m-elias commented Apr 19, 2024

Parsing additional RELPOSNED flags, added functions to get PVT & REL flag data, fixed PVT carr_soln_ parsing to return fixed(2), float(1) or none(0).

parsing additional RELPOSNED flags, added functions to get PVT & REL flag data, fixed PVT carr_soln_ parsing to return fixed(2), float(1) or none(0).
@flybrianfly
Copy link
Contributor

@m-elias, thanks for the contributions. It looks like rel_pos_gnss_fix_ok_ and rel_pos_diff_soln_ are shadowing the current code's fix_ output (FIX_NONE or FIX_DGNSS). I'm not sure what those add, unless the intent was to pull from the UBX-NAV-RELPOSNED packet instead of PVT. The carrier solution flags in UBX-NAV-RELPOSNED should be the same that we're getting in UBX-NAV-PVT carrSoln bits. Have you been seeing inconsistencies between the PVT carrSoln flags and the RELPOSNED flags?

@m-elias
Copy link
Author

m-elias commented May 9, 2024

I was testing your code to use with the AgOpenGPS project's hardware boards. There we use more of REL's flags and I wanted to compare them to PVT's to verify they're both the same. carrSoln should return 3 values as noted in my comment but I don't think it was (I've forgotten those details now). I was also using it to only parse REL by itself so that's why I added in the extra parsing that PVT already had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants