-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds python validation workflows #1
Conversation
378cb26
to
9141a25
Compare
Sounds good. FYI the original repo came with I'm currently finalising linting of the tests, then tentatively this may be almost ready - so yes please don't pull this before checking with me, but I'm linting and testing everything so it should be relatively plain sailing once this first bunch of stuff is complete. |
Thank you, I just realized tox is there and I haven't figured out how to get it to work with pylint but it made getting the workflow for the tests so much easier |
Okay it looks like the workflows work! I'll just leave this until you're ready for it. |
Sorry just pushed up a bunch of stuff that probably has broken your model! I moved the main code into a So tox commands should be:
I'll add a CONTRIBUTING page soon to clarify. |
No worries! I'll check back in tomorrow morning and update this to reflect where it's at. |
Pylint isn't working for me locally so I'm trying to get it to pass here. I can revert the changes to the tests if it's easier to not have them in this branch |
@hughrun ready to merge? |
I'm thinking that it would be helpful to get this in place early, but I'm happy to chill if it's more of a hassle right now than it's worth. And I don't want to have Black create a bunch of conflicts with existing work
Things to fix before this is ready because I need to go to work right now: