-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies, use useSetAtom, use correct AppConfig #19
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!! It'd be great to be able to access more recent features with all these updated packages.
I'm having trouble building / running this locally though:
yarn install
gives me a few new warnings, but still succeeds:
- turns out the warnings here were also in the old code, so can disregard
yarn start
errors out though and shows a blank screen. maybe you have something globally that we don't have in the package.json?
Failed to compile.
Error: [BABEL] /home/whoabuddy/Dev/boom/citycoins-ui/src/index.js: Cannot find module '@babel/plugin-proposal-async-generator-functions'
Will test adding what's missing and report back.
"bn.js": "5.2.1", | ||
"c32check": "2.0.0", | ||
"jotai": "2.1.0", | ||
"lodash.groupby": "4.6.0", | ||
"number-to-words": "github:OmgImAlexis/number-to-words", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this while we're at it (L34: number-to-words)
Following up - I eventually got it to run but don't understand why it was such a hassle, plus some of the layout seems to have shifted up by the logos. Were you seeing this run normally on your end? I'm happy to nuke my config and start over if I missed something. More details below. React version I'm using via nvm: I had to update the pacakge.json start script otherwise it would error out:
I also had to add a bunch of dev dependencies:
|
This PR
useUpdateAtom
withuseSetAtom
AppConfig