String view constexpr #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, its now possible to consteval the c_str() function of states during a visit_current_states. The detail::get_type_name function is not constexpr however, and types falling back to this, wont be consteval.
add string_view support, using the existing functions. note that this does not pull in any headers.
this change unfortunately duplicates get_type_name, but as string_views dont require a zero delimted string, its now always possible to consteval a state instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series makes some methods
constexpr, so that you canconstevalthe string representations - where possible.It also adds support for using string_views, which dont need a terminating zero after the text. This allows further
constevalusage.