🐛 Fix #569 - test.name lifetime with dynamic names

boost-ext · Feb 21, 2024 · 48389c1 · 48389c1
1 parent 788f6b4
commit 48389c1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/include/boost/ut.hpp b/include/boost/ut.hpp
@@ -597,7 +597,7 @@ struct suite_end {
 template <class Test, class TArg = none>
 struct test {
   std::string_view type{};
-  std::string_view name{};
+  std::string name{}; /// might be dynamic
   std::vector<std::string_view> tag{};
   reflection::source_location location{};
   TArg arg{};
@@ -2265,7 +2265,7 @@ struct test {
   template <class... Ts>
   constexpr auto operator=(test_location<void (*)()> _test) {
     on<Ts...>(events::test<void (*)()>{.type = type,
-                                       .name = name,
+                                       .name = std::string{name},
                                        .tag = tag,
                                        .location = _test.location,
                                        .arg = none{},
@@ -2279,7 +2279,7 @@ struct test {
   constexpr auto operator=(Test _test) ->
       typename type_traits::identity<Test, decltype(_test())>::type {
     on<Test>(events::test<Test>{.type = type,
-                                .name = name,
+                                .name = std::string{name},
                                 .tag = tag,
                                 .location = {},
                                 .arg = none{},
@@ -2716,7 +2716,7 @@ template <class F, class T,
     for (const auto& arg : t) {
       detail::on<F>(events::test<F, decltype(arg)>{
               .type = "test",
-              .name = name,
+              .name = std::string{name},
               .tag = {},
               .location = {},
               .arg = arg,
@@ -2733,7 +2733,7 @@ template <
     apply(
         [f, name](const auto&... args) {
           (detail::on<F>(events::test<F, Ts>{.type = "test",
-                                             .name = name,
+                                             .name = std::string{name},
                                              .tag = {},
                                              .location = {},
                                              .arg = args,

diff --git a/test/ut/ut.cpp b/test/ut/ut.cpp
@@ -102,7 +102,7 @@ struct fake_cfg {
 
   struct test_call {
     std::string_view type{};
-    std::string_view name{};
+    std::string name{};
     ut::reflection::source_location location{};
     std::any arg{};
   };
@@ -137,7 +137,7 @@ struct fake_cfg {
   template <class... Ts>
   auto on(ut::events::skip<Ts...> test) -> void {
     skip_calls.push_back(
-        {.type = test.type, .name = test.name, .arg = test.arg});
+        {.type = test.type, .name = std::string{test.name}, .arg = test.arg});
   }
 
   template <class TExpr>