[Feat] 인증된 사용자 라우팅 및 내비게이션 컴포넌트 구현 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PMtHk
approved these changes
Nov 11, 2024
| rightContent: React.ReactNode; | ||
| } | ||
|
|
||
| export function Topbar({ leftContent, rightContent }: TopbarProps) { |
There was a problem hiding this comment.
🟡
레이아웃과 같은 용도로 사용하신거라면 children 을 사용해서 정의하는 건 어떨까요?
(제가 아직 코드상에서 사용 예시를 확인하지 못해 그런 것일 수도 있습니다.)
| function RouteComponent() { | ||
| return ( | ||
| <div> | ||
| <h2>계정 설정 페이지</h2> |
There was a problem hiding this comment.
❓
이곳에다가 바로 컴포넌트를 작성하는 것을 의미하신걸까요?
(pages 디렉토리를 대신해서)
| return ( | ||
| <div> | ||
| <Topbar | ||
| leftContent={ |
There was a problem hiding this comment.
🟡
Tanstack Router 와 문제만 없다면
Children 으로 하위 요소를 받는 것도 좋아보입니다.
jjeonghak
approved these changes
Nov 12, 2024
|
@jjeonghak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
#38
작업 내용
고민
컴포넌트 파일명 컨벤션
shadcn으로 가져온 파일명이 소문자였기 때문에 저도 일단 소문자로 갔는데, 어떻게 하는게 좋을까요?
스크린샷
Screen.Recording.2024-11-11.at.11.42.48.PM.mov