[Feat] 단일 태스크 조회 API 구현 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PMtHk
approved these changes
Nov 11, 2024
| if (!section) { | ||
| throw new NotFoundException('Section not found'); | ||
| } | ||
| const section = await this.findSectionOrThrow(moveTaskRequest.sectionId); | ||
| task.section = section; | ||
|
|
||
| const beforePostion = LexoRank.parse(moveTaskRequest.beforePosition); |
There was a problem hiding this comment.
아악 ,,, 수정해야겠군요 ㅜ
| return new TaskResponse(task); | ||
| } | ||
|
|
||
| private async findTaskOrThrow(id: number) { |
There was a problem hiding this comment.
👍🏻
이런식으로 분리하셨군요!
orThrow 를 쓰시는 분은 거의 못봤는데 자바나 코틀린 쪽 코드같이 보이네요!!! 😃
There was a problem hiding this comment.
재사용성을 최대한 높이는 방향으로 분리하려다보니 그런 느낌이 됐네요 ...!
jjeonghak
approved these changes
Nov 12, 2024
Comment on lines
+4
to
+10
| constructor(task: Task) { | ||
| this.id = task.id; | ||
| this.title = task.title; | ||
| this.description = task.description; | ||
| this.sectionName = task.section.name; | ||
| this.position = task.position; | ||
| } |
There was a problem hiding this comment.
🟢
나중에 저희 constructor 위치 같은 세부적인 것도 통일해야겠네요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
close #58
작업 내용
고민과 학습내용
단일 태스크 조회는 아직 마일스톤에 없어서, 일단 비워두고 올렸습니다.
Task, Section 조회 및 예외처리 코드 함수 분리작업을 먼저 처리해두고 싶어서, 분리하고 바로 사용할 수 있는 단일 조회 API 먼저 구현했습니다 !Task, Section 조회 및 예외처리 코드 함수 분리도 별도 이슈로 분리하는게 나을까요 ?스크린샷